rubenada commented on PR #3901: URL: https://github.com/apache/calcite/pull/3901#issuecomment-2415899601
@jduo , not sure what you mean by "system tests". If you want to add a test with a large dynamic code that fails when this feature is turn off / passes when it is turned on; maybe you could check and adapt the test that was done for the slightly related [CALCITE-3094](https://issues.apache.org/jira/browse/CALCITE-3094) (and then refined in https://issues.apache.org/jira/browse/CALCITE-6593): `LargeGeneratedJoinTest`. The query in that test, with the `JOIN_SELECTOR_COMPACT_CODE_THRESHOLD` disabled, should throw the "code grows beyond 64 KB InternalCompilerException". At that point, turning on the code splitter from this PR, should make the test pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
