asdfgh19 commented on code in PR #3901:
URL: https://github.com/apache/calcite/pull/3901#discussion_r1805839809
##########
core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableInterpretable.java:
##########
@@ -111,7 +111,9 @@ public static Bindable toBindable(Map<String, Object>
parameters,
parameters);
final ClassDeclaration expr = relImplementor.implementRoot(rel, prefer);
- String s = Expressions.toString(expr.memberDeclarations, "\n", false);
+ String s =
+ Expressions.toString(expr.memberDeclarations, "\n", false,
Review Comment:
It seems that code split is not effective here. This is because the code
splitting logic in this pr is implemented in ClassDeclaration, and the
expr.memberDeclarations here is usually MethodDeclaration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
