mihaibudiu commented on code in PR #4404:
URL: https://github.com/apache/calcite/pull/4404#discussion_r2116450807
##########
core/src/test/java/org/apache/calcite/test/RelMetadataTest.java:
##########
@@ -732,7 +732,7 @@ void testColumnOriginsUnion() {
planner.addRule(EnumerableRules.ENUMERABLE_PROJECT_RULE);
planner.addRule(EnumerableRules.ENUMERABLE_FILTER_RULE);
planner.addRule(EnumerableRules.ENUMERABLE_JOIN_RULE);
- planner.addRule(EnumerableRules.ENUMERABLE_LIMIT_SORT_RULE);
+ planner.addRule(EnumerableRules.ENUMERABLE_LIMIT_RULE);
Review Comment:
is this public?
tricky to rename public objects
##########
core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java:
##########
@@ -10798,4 +10798,52 @@ private void
checkLoptOptimizeJoinRule(LoptOptimizeJoinRule rule) {
sql(sql).withRule(CoreRules.AGGREGATE_MIN_MAX_TO_LIMIT)
.check();
}
+
+ /** Test case of
+ * <a
href="https://issues.apache.org/jira/browse/CALCITE-7047";>[CALCITE-7047]
+ * Improve Sort parameter checking in EnumerableLimitSortRule</a>. */
+ @Test void testLimitSortOnlyLimit() {
Review Comment:
A quidem test would be even more convincing.
Or were these tests failing to convert the plan before?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
