xiedeyantu commented on code in PR #4404:
URL: https://github.com/apache/calcite/pull/4404#discussion_r2116690418
##########
core/src/test/java/org/apache/calcite/test/RelMetadataTest.java:
##########
@@ -732,7 +732,7 @@ void testColumnOriginsUnion() {
planner.addRule(EnumerableRules.ENUMERABLE_PROJECT_RULE);
planner.addRule(EnumerableRules.ENUMERABLE_FILTER_RULE);
planner.addRule(EnumerableRules.ENUMERABLE_JOIN_RULE);
- planner.addRule(EnumerableRules.ENUMERABLE_LIMIT_SORT_RULE);
+ planner.addRule(EnumerableRules.ENUMERABLE_LIMIT_RULE);
Review Comment:
This is a test case. The SQL only involves limit. It previously used
EnumerableLimitSortRule, which is actually wrong. Since the previous
implementation did not have strict restrictions, there was no error. It should
use EnumerableLimitRule.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
