NobiGo commented on code in PR #4404:
URL: https://github.com/apache/calcite/pull/4404#discussion_r2116840477
##########
core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableLimitSortRule.java:
##########
@@ -40,6 +40,9 @@ public EnumerableLimitSortRule(Config config) {
@Override public void onMatch(RelOptRuleCall call) {
final Sort sort = call.rel(0);
+ if (sort.fetch == null || sort.getSortExps().isEmpty()) {
Review Comment:
If the user had only added ElementerableLimitSortRule before, would this
change have caused an exception? For me, ElementerableLimitSortRule is not a
supplement to ElementerableLimit and ElementerableSort, but rather a
replacement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
