xiedeyantu commented on code in PR #4404:
URL: https://github.com/apache/calcite/pull/4404#discussion_r2116712183
##########
core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java:
##########
@@ -10798,4 +10798,52 @@ private void
checkLoptOptimizeJoinRule(LoptOptimizeJoinRule rule) {
sql(sql).withRule(CoreRules.AGGREGATE_MIN_MAX_TO_LIMIT)
.check();
}
+
+ /** Test case of
+ * <a
href="https://issues.apache.org/jira/browse/CALCITE-7047">[CALCITE-7047]
+ * Improve Sort parameter checking in EnumerableLimitSortRule</a>. */
+ @Test void testLimitSortOnlyLimit() {
Review Comment:
My reply in jira may explain the problem. Because the cost calculation
methods of these Enumerable operators all use the methods in the base class
Sort. If the operators are all converted from Sort, the cost should be the
same. This will make the plan unstable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]