xiedeyantu commented on code in PR #4404:
URL: https://github.com/apache/calcite/pull/4404#discussion_r2116685015
##########
core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java:
##########
@@ -10798,4 +10798,52 @@ private void
checkLoptOptimizeJoinRule(LoptOptimizeJoinRule rule) {
sql(sql).withRule(CoreRules.AGGREGATE_MIN_MAX_TO_LIMIT)
.check();
}
+
+ /** Test case of
+ * <a
href="https://issues.apache.org/jira/browse/CALCITE-7047";>[CALCITE-7047]
+ * Improve Sort parameter checking in EnumerableLimitSortRule</a>. */
+ @Test void testLimitSortOnlyLimit() {
Review Comment:
EnumerableLimitSortRule is not included in the default rule set, which only
includes EnumerableLimitRule and EnumerableSortRule. So this change has no
effect on other cases. As for whether the execution of EnumerableLimitSort is
correct, there are already many cases that can prove it, so no quidem test is
added here. For this change, observing the change in plan is the most intuitive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
