rubenada commented on code in PR #4465:
URL: https://github.com/apache/calcite/pull/4465#discussion_r2422686754
##########
core/src/main/java/org/apache/calcite/rex/RexSimplify.java:
##########
@@ -767,6 +772,49 @@ private <C extends Comparable<C>> RexNode
simplifyComparison(RexCall e,
return simplifyUsingPredicates(e2, clazz);
}
+
+ /**
+ * If this RexNode is a comparison against NULL, return FALSE, otherwise
return it unchanged.
+ * This is a static simplified version of the function below.
+ */
+ public static RexNode simplifyComparisonWithNull(RexNode e, RexBuilder
rexBuilder) {
Review Comment:
Have you pushed it @mihaibudiu ? I still see the duplicated code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]