iwanttobepowerful commented on code in PR #4647:
URL: https://github.com/apache/calcite/pull/4647#discussion_r2550521036


##########
core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java:
##########
@@ -3453,7 +3453,8 @@ private Pair<RexNode, RelNode> convertOnCondition(
       SqlNode condition,
       RelNode leftRel,
       RelNode rightRel) {
-    bb.setRoot(ImmutableList.of(leftRel, rightRel));
+    bb.setRoot(ImmutableList.of(leftRel, rightRel), leftRel,

Review Comment:
   ```java
       private void setRoot(
           List<RelNode> inputs,
           @Nullable RelNode root,
           boolean hasSystemFields) {
         this.inputs = inputs;
         this.root = root;
         this.systemFieldList.clear();
         if (hasSystemFields) {
           this.systemFieldList.addAll(getSystemFields());
         }
       }
   ```
   
   this expression setting root and hasSystemFields



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to