xiedeyantu commented on code in PR #4647:
URL: https://github.com/apache/calcite/pull/4647#discussion_r2551581497
##########
core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java:
##########
@@ -3453,7 +3453,8 @@ private Pair<RexNode, RelNode> convertOnCondition(
SqlNode condition,
RelNode leftRel,
RelNode rightRel) {
- bb.setRoot(ImmutableList.of(leftRel, rightRel));
+ bb.setRoot(ImmutableList.of(leftRel, rightRel), leftRel,
Review Comment:
Currently, almost all methods for setting the root use `setRoot(RelNode
root, boolean leaf)`. Here, when setting `hasSystemFields`, it uses `root
instanceof LogicalJoin`. I think it might be better to maintain consistency
here, although based on the current logic, the result is the same whether
`hasSystemFieldsis` false or true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
