asolimando commented on code in PR #4647:
URL: https://github.com/apache/calcite/pull/4647#discussion_r2552804865
##########
core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java:
##########
@@ -3453,7 +3453,8 @@ private Pair<RexNode, RelNode> convertOnCondition(
SqlNode condition,
RelNode leftRel,
RelNode rightRel) {
- bb.setRoot(ImmutableList.of(leftRel, rightRel));
+ bb.setRoot(ImmutableList.of(leftRel, rightRel), leftRel,
Review Comment:
Agreed, let's aim for consistency here and let's move the conversation about
it to a separate discussion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
