xiedeyantu commented on code in PR #4647:
URL: https://github.com/apache/calcite/pull/4647#discussion_r2552799517
##########
core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java:
##########
@@ -3453,7 +3453,8 @@ private Pair<RexNode, RelNode> convertOnCondition(
SqlNode condition,
RelNode leftRel,
RelNode rightRel) {
- bb.setRoot(ImmutableList.of(leftRel, rightRel));
+ bb.setRoot(ImmutableList.of(leftRel, rightRel), leftRel,
Review Comment:
@asolimando Yes, I also noticed it's in an unfinished state. Similarly, I
think keeping this extension is good, and it can be temporarily retained.
Alternatively, we can create a separate PR to discuss whether to remove it. So
for the current PR, I still lean towards maintaining consistency and writing it
as `root instanceof LogicalJoin`. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
