asolimando commented on code in PR #4647:
URL: https://github.com/apache/calcite/pull/4647#discussion_r2552786756
##########
core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java:
##########
@@ -3453,7 +3453,8 @@ private Pair<RexNode, RelNode> convertOnCondition(
SqlNode condition,
RelNode leftRel,
RelNode rightRel) {
- bb.setRoot(ImmutableList.of(leftRel, rightRel));
+ bb.setRoot(ImmutableList.of(leftRel, rightRel), leftRel,
Review Comment:
I looked at systems field some time ago and it seems to be used only for
joins and to be a feature that wasn't finally never completely integrated, so I
am not surprised by this discussion.
Not sure how to best handle it, if it's only an internal feature not part of
the public API we could even remove it (although I see why it would be needed
and it's a pity it's not better supported end to end).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
