squakez commented on code in PR #5186:
URL: https://github.com/apache/camel-k/pull/5186#discussion_r1503811034
##########
pkg/trait/trait_types.go:
##########
@@ -511,8 +510,9 @@ func (e *Environment) configureVolumesAndMounts(vols
*[]corev1.Volume, mnts *[]c
// Resources (likely application properties or kamelets)
if e.Resources != nil {
e.Resources.VisitConfigMap(func(configMap *corev1.ConfigMap) {
- // Camel properties
- if configMap.Labels[kubernetes.ConfigMapTypeLabel] ==
"camel-properties" {
+ switch configMap.Labels[kubernetes.ConfigMapTypeLabel] {
+ case "camel-properties":
Review Comment:
It is not part of this PR. I've just changed from an if to a switch here. We
can make a follow up work to do the required cleaning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
