squakez commented on code in PR #5186:
URL: https://github.com/apache/camel-k/pull/5186#discussion_r1504269478
##########
pkg/apis/camel/v1/knative/types.go:
##########
@@ -38,6 +38,7 @@ type CamelServiceDefinition struct {
URL string `json:"url,omitempty"`
Path string `json:"path,omitempty"`
Metadata map[string]string `json:"metadata,omitempty"`
+ SinkBinding bool `json:"sinkBinding,omitempty"`
Review Comment:
I think the `SetSinkBinding` is only called once, not sure to understand the
repeated call you're mentioning. Can you please point in the code?
##########
pkg/trait/camel.go:
##########
@@ -200,10 +207,10 @@ func (t *camelTrait) computeConfigMaps(e *Environment)
[]ctrl.Object {
v1.IntegrationLabel: e.Integration.Name,
},
Annotations: map[string]string{
- "camel.apache.org/source.language":
string(s.InferLanguage()),
- "camel.apache.org/source.loader":
s.Loader,
- "camel.apache.org/source.name":
s.Name,
- "camel.apache.org/source.compression":
strconv.FormatBool(s.Compression),
+ camelSourceLanguageAnnotation:
string(s.InferLanguage()),
+ camelSourceLoaderAnnotation:
s.Loader,
+ camelSourceNameAnnotation:
s.Name,
+ camelSourceCompressionAnnotation:
strconv.FormatBool(s.Compression),
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
