lburgazzoli commented on code in PR #5186:
URL: https://github.com/apache/camel-k/pull/5186#discussion_r1503821804
##########
pkg/util/camel/camel_runtime_catalog.go:
##########
@@ -26,6 +26,18 @@ import (
// NewRuntimeCatalog creates a runtime catalog with the given catalog.
func NewRuntimeCatalog(cat v1.CamelCatalog) *RuntimeCatalog {
catalog := RuntimeCatalog{}
+ if cat.Spec.Runtime.Capabilities != nil {
+ // TODO manage Knative from the catalog
Review Comment:
I guess this is to remove camel-k-knative-impl that comes from the current
catalog so wonder if we really need to do it this way at this stage since then
it would require another change on the operator side once the new catalog will
be released.
I'm assuming leaving the dependency in the classpath for the time being does
not harms the integration since the interceptor/customizer is not triggered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
