lburgazzoli commented on code in PR #5186:
URL: https://github.com/apache/camel-k/pull/5186#discussion_r1503827620
##########
pkg/apis/camel/v1/knative/types.go:
##########
@@ -38,6 +38,7 @@ type CamelServiceDefinition struct {
URL string `json:"url,omitempty"`
Path string `json:"path,omitempty"`
Metadata map[string]string `json:"metadata,omitempty"`
+ SinkBinding bool `json:"sinkBinding,omitempty"`
Review Comment:
My point is that in your code at one point you have a method to mark the
service as sink binding, in fact to flip the boolean, then at the end you have
a if/then/else but such so in fact the check happens at least 3 times so I
wonder if we can avoid this ping pong.
But this is not a big deal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
