[ https://issues.apache.org/jira/browse/CASSANDRA-8584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14347101#comment-14347101 ]
Benedict commented on CASSANDRA-8584: ------------------------------------- +1 I have a slight concern we might spam the log file if there's something systematically wrong, but I also don't want to pollute our code too much. I wonder if we should create a static utility class for logging messages that we don't want to be spammy; we already have at least one place we impose a no-spam rule, and I'm sure we have others we should be and will. > Add strerror output on failed trySkipCache calls > ------------------------------------------------ > > Key: CASSANDRA-8584 > URL: https://issues.apache.org/jira/browse/CASSANDRA-8584 > Project: Cassandra > Issue Type: Improvement > Reporter: Joshua McKenzie > Assignee: Joshua McKenzie > Priority: Trivial > Fix For: 2.1.4 > > Attachments: 8584_v1.txt > > > Since trySkipCache returns an errno rather than -1 and setting errno like our > other CLibrary calls, it's thread-safe and we could print out more helpful > information if we failed to prompt the kernel to skip the page cache. That > system call should always succeed unless we have an invalid fd as it's free > to ignore us. -- This message was sent by Atlassian JIRA (v6.3.4#6332)