[
https://issues.apache.org/jira/browse/CASSANDRA-8584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14355503#comment-14355503
]
Joshua McKenzie commented on CASSANDRA-8584:
--------------------------------------------
[Branch
here|https://github.com/apache/cassandra/compare/trunk...josh-mckenzie:8584]
* Integrated attached logger w/slight rename
* Changed trySkipCache to take path and print on error
* Trivial rename in SSTableReWriter for clarity on which fileDescriptors we
were storing
I can't seem to reproduce the original failure on trySkipCache that led to this
ticket. Good to have this around for future changes though.
> Add strerror output on failed trySkipCache calls
> ------------------------------------------------
>
> Key: CASSANDRA-8584
> URL: https://issues.apache.org/jira/browse/CASSANDRA-8584
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Joshua McKenzie
> Assignee: Joshua McKenzie
> Priority: Trivial
> Fix For: 2.1.4
>
> Attachments: 8584_v1.txt, nospamlogger.txt
>
>
> Since trySkipCache returns an errno rather than -1 and setting errno like our
> other CLibrary calls, it's thread-safe and we could print out more helpful
> information if we failed to prompt the kernel to skip the page cache. That
> system call should always succeed unless we have an invalid fd as it's free
> to ignore us.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
