[
https://issues.apache.org/jira/browse/CASSANDRA-8584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14355691#comment-14355691
]
Joshua McKenzie commented on CASSANDRA-8584:
--------------------------------------------
bq. I think that would actually obviate much of the throttling benefit
You know, I think you're right. I was thinking in terms of throttling
individual errors rather than *classes* of errors but that level of specificity
will just put us largely back where we started. Reverted.
bq. I meant simply to avoid string concatenation, and use {} logging
replacement syntax
It took me *far* longer than it should have to realize you were referring to
the log message in CLibrary.java. I was trying to figure out how our call on
wrapped.warn(s, objects) in ThrottledLogger was somehow not using the varargs
signature... /sigh. That one's on me - apparently today is my day to be obtuse.
Hashing changes simplified, unit test pared down, log message avoiding
concatenation. Branch updated.
> Add strerror output on failed trySkipCache calls
> ------------------------------------------------
>
> Key: CASSANDRA-8584
> URL: https://issues.apache.org/jira/browse/CASSANDRA-8584
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Joshua McKenzie
> Assignee: Joshua McKenzie
> Priority: Trivial
> Fix For: 2.1.4
>
> Attachments: 8584_v1.txt, nospamlogger.txt
>
>
> Since trySkipCache returns an errno rather than -1 and setting errno like our
> other CLibrary calls, it's thread-safe and we could print out more helpful
> information if we failed to prompt the kernel to skip the page cache. That
> system call should always succeed unless we have an invalid fd as it's free
> to ignore us.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
