[
https://issues.apache.org/jira/browse/CASSANDRA-8584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14355520#comment-14355520
]
Benedict commented on CASSANDRA-8584:
-------------------------------------
Can we simply pass a String path to trySkipCache, and just use
reader.getFilename()? It seems to be what we use elsewhere for logging, and it
is perhaps a little neater.
It's probably worth porting the log message to use the varargs parameter of the
warn() method.
If we're renaming the descriptors, perhaps call them sourceFileDescriptors? or
sourceDataComponentFileDescriptors? Or something along those lines... Seems
that the fact they're source, not target, files is valuable information for a
future reader.
Otherwise LGTM +1
> Add strerror output on failed trySkipCache calls
> ------------------------------------------------
>
> Key: CASSANDRA-8584
> URL: https://issues.apache.org/jira/browse/CASSANDRA-8584
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Joshua McKenzie
> Assignee: Joshua McKenzie
> Priority: Trivial
> Fix For: 2.1.4
>
> Attachments: 8584_v1.txt, nospamlogger.txt
>
>
> Since trySkipCache returns an errno rather than -1 and setting errno like our
> other CLibrary calls, it's thread-safe and we could print out more helpful
> information if we failed to prompt the kernel to skip the page cache. That
> system call should always succeed unless we have an invalid fd as it's free
> to ignore us.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
