[
https://issues.apache.org/jira/browse/CASSANDRA-8584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14347117#comment-14347117
]
Joshua McKenzie commented on CASSANDRA-8584:
--------------------------------------------
Thinking back to when I added this, I think we could use some more color
surrounding the error; the strerror output will tell us "invalid file handle"
or some such without specifying the actual file it failed on.
Providing a stack or filename (or both) with the error + throttling the # of
messages would make this a more robust addition I think. What's the other
context in which we impose no-spam, for reference?
> Add strerror output on failed trySkipCache calls
> ------------------------------------------------
>
> Key: CASSANDRA-8584
> URL: https://issues.apache.org/jira/browse/CASSANDRA-8584
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Joshua McKenzie
> Assignee: Joshua McKenzie
> Priority: Trivial
> Fix For: 2.1.4
>
> Attachments: 8584_v1.txt
>
>
> Since trySkipCache returns an errno rather than -1 and setting errno like our
> other CLibrary calls, it's thread-safe and we could print out more helpful
> information if we failed to prompt the kernel to skip the page cache. That
> system call should always succeed unless we have an invalid fd as it's free
> to ignore us.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
