[
https://issues.apache.org/jira/browse/CASSANDRA-10365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14987415#comment-14987415
]
Sylvain Lebresne commented on CASSANDRA-10365:
----------------------------------------------
A few remarks on the "allow nested UDTs patch":
* Why expose/use {{CQLTypeParser.parseRaw()}} instead of
{{CQLTypeParse.parse()}} (In {{SchemaKeyspace.fetchTypes}}).
* I'd prefer keeping the {{Types}} map immutable (even if that means
"duplicating" the map in the ctor, and even if that's theoretically done
multiple time in {{Constructor.build()}}: I can't imagine this being a
performance problem in practice).
* Some comments to explain the difference between {{Types.Builder}} and
{{Types.Constructor}} would be helpful.
* Nit: not very fond of the naming of {{Types.Builder}} versus
{{Types.Constructor}}. I'd have called the latter {{RawBuilder}}, or maybe
{{DependencyResolvingBuilder}}: something that hints at how it differs from the
former, even if it's vague, rather than a non-descriptive synonim.
> Store types by their CQL names in schema tables instead of fully-qualified
> internal class names
> -----------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-10365
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10365
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Aleksey Yeschenko
> Assignee: Aleksey Yeschenko
> Labels: client-impacting
> Fix For: 3.0.0
>
>
> Consider saving CQL types names for column, UDF/UDA arguments and return
> types, and UDT components.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
