[
https://issues.apache.org/jira/browse/CASSANDRA-10365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14989663#comment-14989663
]
Sylvain Lebresne commented on CASSANDRA-10365:
----------------------------------------------
Remarks (and some nits) on the last commits:
* I'm actually not that convinced it's worth pulling a new dependency for
dealing with nested UDT. Granted the previous method was brute-force, but it
was simple and most likely good enough for all practical purposes. In fact, I
wouldn't be that surprised to see the previous method be faster than the new
one on most common cases where you have a vast majority of top-level UDT and a
few 2-3 level deep ones. And none of this is in a very critical path anyway.
Avoiding the new {{jgrapht}} dependecy would avoid the questioning of the next
point.
* {{jgrapht}} uses the "Eclipse Public License". It's mentioned in
http://www.apache.org/legal/resolved.html#category-b: I'm not sure I understand
all the requirements but at the very least we should add a mention to the
{{NOTICE}} file with a link to the library web page. The page also talks about
"requiring an explicit action by the user" and I'm not sure about that. We
might be fine here but I can't personally certify so with a high degree of
confidence.
* Could make {{Types.none()}} return the same singleton object since we do call
it in a bunch of places.
* It sadens me that the type of the {{Types.types}} field is not
{{ImmutableMap}} (the reason seems to be to that the {{RawBuilder}} abuses
{{Types}}).
* In {{SchemaKeyspace.fetchTypes}}, the use of {{Types}} have been expended to
their fqn ({{org.apache.cassandra.schema.Types}}). Not a big deal but I don't
think that's necessary.
> Store types by their CQL names in schema tables instead of fully-qualified
> internal class names
> -----------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-10365
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10365
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Aleksey Yeschenko
> Assignee: Aleksey Yeschenko
> Labels: client-impacting
> Fix For: 3.0.0
>
>
> Consider saving CQL types names for column, UDF/UDA arguments and return
> types, and UDT components.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
