[
https://issues.apache.org/jira/browse/CASSANDRA-10365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14989790#comment-14989790
]
Aleksey Yeschenko commented on CASSANDRA-10365:
-----------------------------------------------
bq. Could make Types.none() return the same singleton object since we do call
it in a bunch of places.
Done. Can do some for other metadata containers, but won't in this ticket.
bq. In SchemaKeyspace.fetchTypes, the use of Types have been expended to their
fqn (org.apache.cassandra.schema.Types). Not a big deal but I don't think
that's necessary.
Corrected.
bq. at the very least we should add a mention to the NOTICE file with a link to
the library web page
Done.
bq. It sadens me that the type of the Types.types field is not ImmutableMap
(the reason seems to be to that the RawBuilder abuses Types).
Given that it will always realistically be an ImmutableMap, I'm not even
saddened. Well, just a little bit, but not it actually feels cleaner to me this
way.
Force-pushed the new commit on top of a rebased branch.
> Store types by their CQL names in schema tables instead of fully-qualified
> internal class names
> -----------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-10365
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10365
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Aleksey Yeschenko
> Assignee: Aleksey Yeschenko
> Labels: client-impacting
> Fix For: 3.0.0
>
>
> Consider saving CQL types names for column, UDF/UDA arguments and return
> types, and UDT components.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
