[
https://issues.apache.org/jira/browse/CASSANDRA-7279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14007282#comment-14007282
]
Sylvain Lebresne commented on CASSANDRA-7279:
---------------------------------------------
But wait. What I'm saying is that the CQL3 code never generate overlapping
ranges. If it does, it's a bug that needs to be fixed but that I'm not aware of.
So that this call to removeOverlappingSlices is doing work that, at least for
CQL3, is wasting good cpu cycles. If we're freaked out that the CQL3 might
create overlapping slices by mistake in the future, I guess I'm not opposed to
re-adding validation of the slices (preferably in an assert), but validating
the slices is much simpler than what removeOverlappingSlices does (it doesn't
have to allocate a Comparator object or sort an array that is already sorted).
And if thrift is the only place that accepts overlapping slices and does
de-ovelapping silently, then it's only there that we should deoverlap.
> MultiSliceTest.test_with_overlap* unit tests failing in trunk
> -------------------------------------------------------------
>
> Key: CASSANDRA-7279
> URL: https://issues.apache.org/jira/browse/CASSANDRA-7279
> Project: Cassandra
> Issue Type: Bug
> Components: Tests
> Reporter: Michael Shuler
> Assignee: T Jake Luciani
> Priority: Minor
> Fix For: 2.1 rc1
>
> Attachments: 7279-trunk.txt, 7279-trunkv2.txt, 7279-trunkv3.txt,
> 7279-trunkv4.txt
>
>
> Example:
> https://cassci.datastax.com/job/trunk_utest/623/testReport/org.apache.cassandra.thrift/MultiSliceTest/
--
This message was sent by Atlassian JIRA
(v6.2#6252)
