[ 
https://issues.apache.org/jira/browse/CASSANDRA-7279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14007326#comment-14007326
 ] 

Sylvain Lebresne commented on CASSANDRA-7279:
---------------------------------------------

bq. Does any CQL code generate multiple ranges at all?

Yes it does.

bq. CASSANDRA-4762 would add this to cql

I'm pretty sure CASSANDRA-4762 can be done so that slices are generated 
non-overlapping by construction. And if it turns out that it's really much more 
convenient to generate overlapping slices and de-overlap after the fact, then 
fine, we can call the deoverlapping code then. But that's still not a reason to 
call it everytime when there is many cases where we know it's useless.

bq. Is the CPU cost really that high here? It's only run once per query

But if it's useless, it's kind of too costly, isn't it ? What is the downsides 
of doing the de-overlapping only when we need to and just adding a check in an 
assertion otherwise? I doubt it'll be much more code if any. I'm fine providing 
a patch doing that if it's just a matter of "you'd rather not spend more time 
on this" (which I respect).

> MultiSliceTest.test_with_overlap* unit tests failing in trunk
> -------------------------------------------------------------
>
>                 Key: CASSANDRA-7279
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-7279
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tests
>            Reporter: Michael Shuler
>            Assignee: T Jake Luciani
>            Priority: Minor
>             Fix For: 2.1 rc1
>
>         Attachments: 7279-trunk.txt, 7279-trunkv2.txt, 7279-trunkv3.txt, 
> 7279-trunkv4.txt
>
>
> Example:
> https://cassci.datastax.com/job/trunk_utest/623/testReport/org.apache.cassandra.thrift/MultiSliceTest/



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to