[
https://issues.apache.org/jira/browse/CASSANDRA-7279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14008398#comment-14008398
]
Edward Capriolo commented on CASSANDRA-7279:
--------------------------------------------
The problem as I see it, is the bulk of the testing was in
ColumnFamilyStoreTest, so the other collaborating components are not clear with
pre/post conditions. Since none of the collaborators are defined as who handles
the de duplication it is a very open ended discussion. Review this table:
||Component||Accepts overlaping ranges?||Action||
|Cassandra.Server multiSliceRequest|Yes|Blindly pass Along|
|SliceQueryFilter (with Jake's Patch)|Yes|Deduplicate and de-overlap|
|ColumnFamilyStore|Yes| Never receives an overlapped slice |
Suggestion. Construct a similar table for the new current and/or new CQL paths.
Use that determine where the overlapping check should be. Go back and define in
each piece of the API what they do and do not accept.
> MultiSliceTest.test_with_overlap* unit tests failing in trunk
> -------------------------------------------------------------
>
> Key: CASSANDRA-7279
> URL: https://issues.apache.org/jira/browse/CASSANDRA-7279
> Project: Cassandra
> Issue Type: Bug
> Components: Tests
> Reporter: Michael Shuler
> Assignee: T Jake Luciani
> Priority: Minor
> Fix For: 2.1 rc1, 3.0
>
> Attachments: 7279-trunk.txt, 7279-trunkv2.txt, 7279-trunkv3.txt,
> 7279-trunkv4.txt
>
>
> Example:
> https://cassci.datastax.com/job/trunk_utest/623/testReport/org.apache.cassandra.thrift/MultiSliceTest/
--
This message was sent by Atlassian JIRA
(v6.2#6252)
