weizhouapache commented on a change in pull request #5687:
URL: https://github.com/apache/cloudstack/pull/5687#discussion_r753149008
##########
File path:
server/src/main/java/com/cloud/resourcelimit/ResourceLimitManagerImpl.java
##########
@@ -521,13 +520,21 @@ public void checkResourceLimit(final Account account,
final ResourceType type, l
}
final Project projectFinal = project;
+
+ // Check account limits. If it's unlimited then don't lock the db rows
+ long accountResourceLimit =
findCorrectResourceLimitForAccount(account, type);
+ if (Resource.RESOURCE_UNLIMITED == accountResourceLimit) {
Review comment:
> @weizhouapache if the account resource limit is -1 then the resource
count are not incremented for this account and so the resource count wont be
incremented for domain as well. so why do we need to do extra check?
>
@ravening
Even if the account can use unlimited resource, the domain resource limit is
still effective.
why not ignore the domain resource check and not updated the resource count
(of account and domain) ?
> if domain has two accounts: A with limit as -1 and B with limit as 100,
then account A can use unlimited resources. so the used account resource value
will not be added to domain resource count
why not ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
