ravening commented on a change in pull request #5687:
URL: https://github.com/apache/cloudstack/pull/5687#discussion_r753165644
##########
File path:
server/src/main/java/com/cloud/resourcelimit/ResourceLimitManagerImpl.java
##########
@@ -521,13 +520,21 @@ public void checkResourceLimit(final Account account,
final ResourceType type, l
}
final Project projectFinal = project;
+
+ // Check account limits. If it's unlimited then don't lock the db rows
+ long accountResourceLimit =
findCorrectResourceLimitForAccount(account, type);
+ if (Resource.RESOURCE_UNLIMITED == accountResourceLimit) {
Review comment:
@weizhouapache
lets say a domain has limit of 100 cpu count and lets the account under this
domain has cpu limit as -1.
Technically we can create as many vm's in this account without any cpu limit
restrictions as the limit for this account is -1. So I can create 100 vm's each
with 10 cpu cores thus making a total of 1000 cpu count . but if i increase the
domain resource limit then i will get error as soon as 100 is reached.
So in that case whats the use of having -1 as resource limit for account?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
