DaanHoogland commented on code in PR #10710:
URL: https://github.com/apache/cloudstack/pull/10710#discussion_r2309823680
##########
server/src/main/java/com/cloud/network/router/CommandSetupHelper.java:
##########
@@ -542,11 +543,11 @@ public void createApplyIpv6FirewallRulesCommands(final
List<? extends FirewallRu
}
public void createFirewallRulesCommands(final List<? extends FirewallRule>
rules, final VirtualRouter router, final Commands cmds, final long
guestNetworkId) {
- final List<FirewallRuleTO> rulesTO = new ArrayList<FirewallRuleTO>();
+ final List<FirewallRuleTO> rulesTO = new ArrayList<>();
String systemRule = null;
Boolean defaultEgressPolicy = false;
if (rules != null) {
- if (rules.size() > 0) {
+ if (!rules.isEmpty()) {
Review Comment:
however the isEmpty check can be merged with the next if within it. will do
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
