bradh352 commented on code in PR #11932:
URL: https://github.com/apache/cloudstack/pull/11932#discussion_r2473904516
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java:
##########
@@ -1340,7 +1340,11 @@ public String getMemBalloonStatsPeriod() {
@Override
public String toString() {
StringBuilder memBalloonBuilder = new StringBuilder();
- memBalloonBuilder.append("<memballoon model='" + memBalloonModel +
"'>\n");
+ memBalloonBuilder.append("<memballoon model='" + memBalloonModel +
"'");
+ if (memBalloonModel != MemBalloonModel.NONE) {
Review Comment:
I was thinking it doesn't look necessary. This was introduced in v6.9.0. I
checked both the oldest non-EOL enterprise distros and they all have newer
versions:
* ubuntu 22.04 LTS: 8.0.0 https://launchpad.net/ubuntu/jammy/+source/libvirt
* CentOS/AlmaLinux/RockyLinux 9: 10.10.0
https://download.rockylinux.org/pub/rocky/9/AppStream/x86_64/os/Packages/l/libvirt-10.10.0-7.7.el9_6.x86_64.rpm
even EOL versions like CentOS 8 had v 8.0.0...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
