bradh352 commented on code in PR #11932:
URL: https://github.com/apache/cloudstack/pull/11932#discussion_r2474336054
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java:
##########
@@ -1340,7 +1340,11 @@ public String getMemBalloonStatsPeriod() {
@Override
public String toString() {
StringBuilder memBalloonBuilder = new StringBuilder();
- memBalloonBuilder.append("<memballoon model='" + memBalloonModel +
"'>\n");
+ memBalloonBuilder.append("<memballoon model='" + memBalloonModel +
"'");
+ if (memBalloonModel != MemBalloonModel.NONE) {
Review Comment:
This was added in qemu 5.1 and requires host kernel 5.7.
ubuntu 22.04 is qemu 6.2: https://launchpad.net/ubuntu/jammy/+source/qemu
rocky linux 9 is qemu 9.1:
https://download.rockylinux.org/pub/rocky/9/AppStream/x86_64/os/Packages/q/qemu-kvm-9.1.0-15.el9_6.9.x86_64.rpm
So no problems there either.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
