koushik-das commented on a change in pull request #2081: CLOUDSTACK-9894
Separate creation and backup operations for a volume snapshot
URL: https://github.com/apache/cloudstack/pull/2081#discussion_r123679658
##########
File path: engine/schema/src/com/cloud/storage/dao/VolumeDao.java
##########
@@ -122,4 +122,6 @@
* @return returns true if transaction is successful.
*/
boolean updateUuid(long srcVolId, long destVolId);
+
+ List<VolumeVO> findRootVolumeByInstance(long vmId);
Review comment:
There are existing methods like
List<VolumeVO> findByInstanceAndType(long id, Volume.Type vType);
List<VolumeVO> findReadyRootVolumesByInstance(long instanceId);
Is there really a need to add the new method?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
