koushik-das commented on a change in pull request #2081: CLOUDSTACK-9894
Separate creation and backup operations for a volume snapshot
URL: https://github.com/apache/cloudstack/pull/2081#discussion_r123680699
##########
File path:
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/SnapshotServiceImpl.java
##########
@@ -547,4 +555,33 @@ protected Void
syncSnapshotCallBack(AsyncCallbackDispatcher<SnapshotServiceImpl,
return null;
}
+
+ @Override
+ public void processEventOnSnapshotObject(SnapshotInfo snapshot,
Snapshot.Event event) {
+ SnapshotObject object = (SnapshotObject)snapshot;
+ try {
+ object.processEvent(event);
+ } catch (NoTransitionException e) {
+ s_logger.debug("Unable to update the state " + e.toString());
+ }
+ }
+
+ @Override
+ public void performEventsOnBackupFaiureAndRemove(SnapshotInfo snapshot) {
Review comment:
Multiple DB operations are happening, should be done in a tx
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
