koushik-das commented on a change in pull request #2081: CLOUDSTACK-9894
Separate creation and backup operations for a volume snapshot
URL: https://github.com/apache/cloudstack/pull/2081#discussion_r123686029
##########
File path: server/src/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -2608,6 +2609,21 @@ public UserVm destroyVm(DestroyVMCmd cmd) throws
ResourceUnavailableException, C
CallContext ctx = CallContext.current();
long vmId = cmd.getId();
boolean expunge = cmd.getExpunge();
+ // check if VM exists
Review comment:
What is the purpose of these checks? If at all required should be done after
validating that caller has proper permission as done immediately after these
changes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
