koushik-das commented on a change in pull request #2081: CLOUDSTACK-9894
Separate creation and backup operations for a volume snapshot
URL: https://github.com/apache/cloudstack/pull/2081#discussion_r123679064
##########
File path:
engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/SnapshotService.java
##########
@@ -29,4 +31,8 @@
void syncVolumeSnapshotsToRegionStore(long volumeId, DataStore store);
void cleanupVolumeDuringSnapshotFailure(Long volumeId, Long snapshotId);
+
+ void processEventOnSnapshotObject(SnapshotInfo snapshot, Event event);
+
+ void performEventsOnBackupFaiureAndRemove(SnapshotInfo snapshot);
Review comment:
The first method is more generic, why there is a need for the more specific
event processing method?
nit- spelling of failure is not correct in the 2nd one
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
