koushik-das commented on a change in pull request #2081: CLOUDSTACK-9894
Separate creation and backup operations for a volume snapshot
URL: https://github.com/apache/cloudstack/pull/2081#discussion_r123684095
##########
File path:
framework/jobs/src/org/apache/cloudstack/framework/jobs/impl/AsyncJobManagerImpl.java
##########
@@ -1013,6 +1030,12 @@ public void
doInTransactionWithoutResult(TransactionStatus status) {
}
_queueMgr.purgeAsyncJobQueueItemId(job.getId());
}
+ List<SnapshotDetailsVO> snapshotList =
_snapshotDetailsDao.findDetails(MSID, Long.toString(msid), false);
Review comment:
In this case msid saved in DB is used, but while storing it is always
computed? Use the ManagementServerNode.getManagementServerId() while storing as
well instead of computing every time
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
