mike-tutkowski commented on issue #2761: Add managed storage pool constraints to MigrateWithVolume API method URL: https://github.com/apache/cloudstack/pull/2761#issuecomment-408270678 @rafaelweingartner Let's say the user provided a (target) managed storage pool for the volume in question. If that's the case, then we just want to make sure that this managed storage pool is the same as the storage pool of the volume. We don't care if it's a zone-wide managed storage pool or a cluster-wide managed storage pool in this case (either is acceptable). We just want to make sure that it's the same storage pool. Those checks are captured in executeManagedStorageChecksWhenTargetStoragePoolProvided (which does not care about the zone-wide requirement). However, if you don't provide a storage pool for the volume in question and it is located on managed storage, then we - in case you are doing a migration of the VM from one cluster to another - need to only make sure the managed storage pool is zone wide. If it turns out that this managed storage pool is cluster wide, then the user needs to explicitly pass the volume/target storage pool in as a parameter to the API command when performing the migration of the VM (with its storage) from one cluster to another. At least this is how it used to work. One alternative is to keep a single managed-storage method for checking, but to drop the zone-wide requirement. In fact, I think we can get away with only calling that check method once then. Take a look at this proposal: https://github.com/mike-tutkowski/cloudstack/commit/bea1dad5b84bb80ba1f1297a69a1daea1c4ec736
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
