mike-tutkowski commented on issue #2761: Add managed storage pool constraints 
to MigrateWithVolume API method
URL: https://github.com/apache/cloudstack/pull/2761#issuecomment-409676248
 
 
   You are really close now, @rafaelweingartner. It looks like you missed the 
suggestions at the bottom of my previous diff. I put those suggestions here for 
you to look at: 
https://github.com/mike-tutkowski/cloudstack/commit/f22e03f1866fd011e080219645ef695e751b2c0e.
   
   Here's a copy/paste of part of my previous comment from above that relates 
to this diff:
   
   "The other area I changed was in the createStoragePoolMappingsForVolumes 
method. It does not need to call executeManagedStorageChecks. However, we do 
need to handle managed storage specially here. If the storage pool is managed, 
make sure the target host can see this storage pool."

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to