mike-tutkowski commented on issue #2761: Add managed storage pool constraints to MigrateWithVolume API method URL: https://github.com/apache/cloudstack/pull/2761#issuecomment-408535487 I can check a little later when I am back at the computer. If you take a look at the link I sent you yesterday (or the day before) that has my suggested code, there is only one method that does any manage storage checks and it is only called in one place. On Jul 27, 2018, at 2:42 PM, Rafael Weingärtner <[email protected]<mailto:[email protected]>> wrote: @rafaelweingartner commented on this pull request. ________________________________ In engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java<https://github.com/apache/cloudstack/pull/2761#discussion_r205894041>: > StoragePoolVO currentPool = _storagePoolDao.findById(volume.getPoolId()); - if (ScopeType.HOST.equals(currentPool.getScope())) { - createVolumeToStoragePoolMappingIfNeeded(profile, targetHost, volumeToPoolObjectMap, volume, currentPool); + + executeManagedStorageChecksWhenTargetStoragePoolNotProvided(targetHost, currentPool, volume); That is exactly what I understood before. What I do not understand is why we need those executeManagedStorageChecksWhenTargetStoragePoolNotProvided and executeManagedStorageChecksWhenTargetStoragePoolProvided instead of a single executeManagedStorageChecks. Can you check at the last commit I pushed? Why would we need to divide that executeManagedStorageChecks into two other methods? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://github.com/apache/cloudstack/pull/2761#discussion_r205894041>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AC4SH1TlHSt40KwxChgxDYBIXB4FLLpLks5uK3svgaJpZM4Va8cN>.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
