mike-tutkowski commented on issue #2761: Add managed storage pool constraints to MigrateWithVolume API method URL: https://github.com/apache/cloudstack/pull/2761#issuecomment-409053890 Hi @rafaelweingartner Yes, just a couple, though. Here is a diff of my recommended final changes: https://github.com/mike-tutkowski/cloudstack/commit/48fb1ecaf70dc9eb364a58eabf51504926e9c5eb. To summarize them: The executeManagedStorageChecks method is only called from one place. It does not require a check to make sure the managed storage pool is at the zone level. Also, instead of executeManagedStorageChecks checking if the current pool's cluster ID is equal to that of the cluster ID of the target host, we just compare the IDs of the current and target pools (because we don't allow you to change the managed storage pool during this operation). I needed to change what’s passed in to the method to make this work. Comparing the cluster ID of the current pool to the cluster ID of the target host won’t work with zone-wide primary storage. The other area I changed was in the createStoragePoolMappingsForVolumes method. It does not need to call executeManagedStorageChecks. However, we do need to handle managed storage specially here. If the storage pool is managed, make sure the target host can see this storage pool.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
