DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE]
Health check feature for virtual router
URL: https://github.com/apache/cloudstack/pull/3575#discussion_r358692438
##########
File path:
core/src/main/java/com/cloud/agent/resource/virtualnetwork/facade/AbstractConfigItemFacade.java
##########
@@ -127,7 +127,10 @@ private static String appendUuidToJsonFiles(final String
filename) {
final ConfigItem configFile = new
FileConfigItem(VRScripts.CONFIG_PERSIST_LOCATION, remoteFilename,
gson.toJson(configuration));
cfg.add(configFile);
- final ConfigItem updateCommand = new
ScriptConfigItem(VRScripts.UPDATE_CONFIG, remoteFilename);
+ // By default keep files in processed cache on VR
+ final String args = configuration.shouldDeleteFromProcessedCache() ?
remoteFilename + " false" : remoteFilename;
+
+ final ConfigItem updateCommand = new
ScriptConfigItem(VRScripts.UPDATE_CONFIG, args);
Review comment:
ok, let me make my question more explicit; Do we have a
processed-cache-cleaning facility, or is this specific to the files being
created in this command? There is an issue out for the more generic problem!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
