DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE]
Health check feature for virtual router
URL: https://github.com/apache/cloudstack/pull/3575#discussion_r365867009
##########
File path: systemvm/debian/root/health_checks/dns_check.py
##########
@@ -39,12 +41,15 @@ def main():
break
if not foundEntry:
- print "Missing entry in /etc/hosts - " + vM["ip"] + \
- " " + vM["vmName"]
- exit(1)
-
- print "All " + str(len(vMs)) + " VMs are present in /etc/hosts"
- exit(0)
+ failedCheck = True
+ failureMessage = failureMessage + vM["ip"] + " " + vM["vmName"] +
"\n"
Review comment:
same as the dhcp check: if multiple errors we log only the last one?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
