DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE]
Health check feature for virtual router
URL: https://github.com/apache/cloudstack/pull/3575#discussion_r365866174
##########
File path: systemvm/debian/root/health_checks/dhcp_check.py
##########
@@ -41,11 +43,15 @@ def main():
break
if not foundEntry:
- print "Missing elements in dhcphosts.txt - " + entry
- exit(1)
-
- print "All " + str(len(vMs)) + " VMs are present in dhcphosts.txt"
- exit(0)
+ failedCheck = True
+ failureMessage = failureMessage + entry + "\n"
Review comment:
this is inside a loop. if we detect multiple failures we just log the last
one?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
