DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE]
Health check feature for virtual router
URL: https://github.com/apache/cloudstack/pull/3575#discussion_r365871268
##########
File path:
server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
##########
@@ -1454,7 +1456,7 @@ private RouterHealthCheckResultVO
parseHealthCheckVOFromJson(final long routerId
}
private GetRouterMonitorResultsAnswer
fetchAndUpdateRouterHealthChecks(DomainRouterVO router, boolean
performFreshChecks) {
- if (!RouterHealthChecksEnabled.valueIn(router.getDataCenterId())) {
+ if (!RouterHealthChecksEnabled.value()) {
Review comment:
the value was changed to scope zone, so why not ask for valueIn(Zone)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
