DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] 
Health check feature for virtual router
URL: https://github.com/apache/cloudstack/pull/3575#discussion_r365868181
 
 

 ##########
 File path: systemvm/debian/root/health_checks/iptables_check.py
 ##########
 @@ -60,12 +65,15 @@ def main():
                     break
 
             if not foundPfEntryList:
-                print "Missing port forwarding rules in Iptables - "
-                print pfEntryListExpected
-                exit(1)
+                failedCheck = True
+                failureMessage = failureMessage + str(pfEntryListExpected) + 
"\n"
 
 Review comment:
   again, only the last error matters?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to