stevedlawrence commented on a change in pull request #343: Daffodil 2302 fixes
external variables API difficulties
URL: https://github.com/apache/incubator-daffodil/pull/343#discussion_r400871541
##########
File path: daffodil-japi/src/main/scala/org/apache/daffodil/japi/Daffodil.scala
##########
@@ -122,8 +125,14 @@ class Compiler private[japi] () {
* @throws java.io.IOException if an I/O error occurs while reading the
schemaFile
*/
@throws(classOf[java.io.IOException])
- def compileFile(schemaFile: File): ProcessorFactory = {
- val pf = sCompiler.compileFile(schemaFile)
+ def compileFile(schemaFile: File): ProcessorFactory =
compileFile(schemaFile, None, None)
+
+ @throws(classOf[java.io.IOException])
+ def compileFile(schemaFile: File,
+ optRootName: Option[String],
+ optRootNamespace: Option[String]): ProcessorFactory = {
+
Review comment:
Needs javadoc. Also, this is the Java API so an ``Option`` might be awkward
to use for someone not familar with Scala. I think the standard Java practice
is to allow these to be null if not provided, and we can just convert to Option?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
