stevedlawrence commented on a change in pull request #343: Daffodil 2302 fixes
external variables API difficulties
URL: https://github.com/apache/incubator-daffodil/pull/343#discussion_r400871687
##########
File path: daffodil-japi/src/main/scala/org/apache/daffodil/japi/Daffodil.scala
##########
@@ -136,9 +145,14 @@ class Compiler private[japi] () {
* @throws java.io.IOException if an I/O error occurs while reading the uri
*/
@throws(classOf[java.io.IOException])
- def compileSource(uri: URI): ProcessorFactory = {
+ def compileSource(uri: URI): ProcessorFactory = compileSource(uri, None,
None)
+
+ @throws(classOf[java.io.IOException])
+ def compileSource(uri: URI,
+ optRootName: Option[String],
+ optRootNamespace: Option[String]): ProcessorFactory = {
Review comment:
Same comment about Option here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
