stevedlawrence commented on a change in pull request #343: Daffodil 2302 fixes
external variables API difficulties
URL: https://github.com/apache/incubator-daffodil/pull/343#discussion_r400874050
##########
File path: daffodil-japi/src/main/scala/org/apache/daffodil/japi/Daffodil.scala
##########
@@ -189,8 +203,9 @@ class Compiler private[japi] () {
* @param namespace namespace of the root node. Set to empty string to
specify
* no namespace. Set to to NULL to figure out the namespace.
*/
+ @deprecated("Pass argument to compileSource, or compileFile.", "Since 2.6.0")
Review comment:
I think it's reasonable to change the JAPI/SAPI to add deprecations. I feel
like we really want to encourage people to move to the other functions so we
can eventually remove all these setters.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
